refactor(ui-dom-utils): update findFocusable logic
#1223
Conversation
|
|
|
instructure-ui-ci seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
NamNg1121
changed the title
findFocusable logicfindFocusable logic
|
Preview URL: https://1223--preview-instui.netlify.app |
| @@ -83,12 +83,7 @@ function findFocusable( | |||
|
|
|||
| function hidden(element: Element | Node) { | |||
| const cs = getComputedStyle(element) | |||
| return ( | |||
There was a problem hiding this comment.
This refers to a ticket on the Slack channel. After researching the issue, I discovered that the developers who were implementing the feature had left. Therefore, I decided to remove the feature and test how it affected the components. Overall, everything was fine in the manual test. I suggest writing unit tests.
matyasf
force-pushed
the
INSTUI-3786-update-focusable-component-for-testing-environments
branch
from
ce51a7a
to
01e4ef8
Compare
…display is 'none' The code of findFocusable was lifted from some ancient JQuery UI helper. For some unknown reason it treats an element as non-focusable if its CSS display prop is not inline and its size is 0 or less. It seems to work fine without this criteria, and we could not find any reason why this clause was added in the first place.
matyasf
force-pushed
the
INSTUI-3786-update-focusable-component-for-testing-environments
branch
from
01e4ef8
to
c41a3ee
Compare
|
The code of It seems to work fine without this second criteria, and we could not find any reason why this clause was added in the first place (even when looking at JQuery UI's commit log). |
HerrTopi
deleted the
INSTUI-3786-update-focusable-component-for-testing-environments
branch
No description provided.